Drop support for Ruby 2.3 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit drops support for Ruby 2.3 and suppresses the following
`Gemspec/RequiredRubyVersion` offense.
```console
% cd path/to/rubocop-rake
% bundle exec rake
(snip)
Offenses:
rubocop-rake.gemspec:14:32: C: Gemspec/RequiredRubyVersion:
required_ruby_version (2.3, declared in rubocop-rake.gemspec) and
TargetRubyVersion (2.4, which may be specified in .rubocop.yml) should
be equal.
spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
25 files inspected, 1 offense detected
```
This commit fixes the following `RSpec/FactoryBot/CreateList` error. ```console % cd path/to/rubocop-rake % bundle exec rake (snip) An error occurred while RSpec/FactoryBot/CreateList cop was inspecting /Users/koic/src/github.com/rubocop-hq/rubocop-rake/spec/spec_helper.rb:15:15. To see the complete backtrace run rubocop -d. ```
koic
force-pushed
the
drop_support_ruby_23
branch
from
cb0ff0c
to
d884630
Compare
bbatsov
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for Ruby 2.3 and suppresses the following
Gemspec/RequiredRubyVersionoffense.And this PR fixes the following
RSpec/FactoryBot/CreateListerror.