Merge pull request #1668 from splattael/named-subject-block-without-body

Fix `RSpec/NamedSubject` when block has no body

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Fix a false negative for `RSpec/Pending` when  `it` without body. ([@ydah])
 - Add new `RSpec/ReceiveMessages` cop. ([@ydah])
 - Add `AllowedIdentifiers` and `AllowedPatterns` configuration option to `RSpec/IndexedLet`.  ([@ydah])
+- Fix `RSpec/NamedSubject` when block has no body. ([@splattael])
 
 ## 2.22.0 (2023-05-06)
 
@@ -867,6 +868,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@seanpdoyle]: https://github.com/seanpdoyle
 [@sl4vr]: https://github.com/sl4vr
 [@smcgivern]: https://github.com/smcgivern
+[@splattael]: https://github.com/splattael
 [@stephannv]: https://github.com/stephannv
 [@t3h2mas]: https://github.com/t3h2mas
 [@tdeo]: https://github.com/tdeo

lib/rubocop/cop/rspec/named_subject.rb

@@ -145,7 +145,7 @@ def nearest_subject(node)
         end
 
         def find_subject(block_node)
-          block_node.body.child_nodes.find { |send_node| subject?(send_node) }
+          block_node.body&.child_nodes&.find { |send_node| subject?(send_node) }
         end
       end
     end

spec/rubocop/cop/rspec/named_subject_spec.rb

@@ -153,6 +153,16 @@ def foo
         end
       RUBY
     end
+
+    it 'ignores subject when block has no body' do
+      expect_no_offenses(<<-RUBY)
+        it "is a User" do
+          subject.each do
+            # empty body
+          end
+        end
+      RUBY
+    end
   end
 
   context 'when IgnoreSharedExamples is false' do