Merge pull request #1685 from rubocop/mark-unsafe-for-negation-be-valid

Mark to `Safe: false` for `RSpec/Rails/NegationBeValid` cop
rubocop · Aug 6, 2023 · 4071f9b · 4071f9b
2 parents d66612b + 6adeda2
commit 4071f9b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+- Mark to `Safe: false` for `RSpec/Rails/NegationBeValid`  cop. ([@ydah])
+
 ## 2.23.0 (2023-07-30)
 
 - Add new `RSpec/Rails/NegationBeValid` cop. ([@ydah])

diff --git a/config/default.yml b/config/default.yml
@@ -1108,12 +1108,14 @@ RSpec/Rails/MinitestAssertions:
 
 RSpec/Rails/NegationBeValid:
   Description: Enforces use of `be_invalid` or `not_to` for negated be_valid.
+  Safe: false
   EnforcedStyle: not_to
   SupportedStyles:
     - not_to
     - be_invalid
   Enabled: pending
   VersionAdded: '2.23'
+  VersionChanged: "<<next>>"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/NegationBeValid
 
 RSpec/Rails/TravelAround:

diff --git a/docs/modules/ROOT/pages/cops_rspec_rails.adoc b/docs/modules/ROOT/pages/cops_rspec_rails.adoc
@@ -267,14 +267,19 @@ expect(b).not_to eq(a)
 | Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
-| Yes
-| Yes
+| No
+| Yes (Unsafe)
 | 2.23
-| -
+| <<next>>
 |===
 
 Enforces use of `be_invalid` or `not_to` for negated be_valid.
 
+=== Safety
+
+This cop is unsafe because it cannot guarantee that
+the test target is an instance of `ActiveModel::Validations``.
+
 === Examples
 
 ==== EnforcedStyle: not_to (default)

diff --git a/lib/rubocop/cop/rspec/rails/negation_be_valid.rb b/lib/rubocop/cop/rspec/rails/negation_be_valid.rb
@@ -6,6 +6,10 @@ module RSpec
       module Rails
         # Enforces use of `be_invalid` or `not_to` for negated be_valid.
         #
+        # @safety
+        #   This cop is unsafe because it cannot guarantee that
+        #   the test target is an instance of `ActiveModel::Validations``.
+        #
         # @example EnforcedStyle: not_to (default)
         #   # bad
         #   expect(foo).to be_invalid