Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new "Identity Comparison" rule #835

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Add new "Identity Comparison" rule #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,19 @@ something = something && something.downcase
something &&= something.downcase
----

=== Identity Comparison [[identity-comparison]]

Prefer `equal?` over `==` when comparing `object_id`. `Object#equal?` is provided to compare objects for identity, and in contrast `Object#==` is provided for the purpose of doing value comparison.

[source,ruby]
----
# bad
foo.object_id == bar.object_id

# good
foo.equal?(bar)
----

=== Explicit Use of the Case Equality Operator [[no-case-equality]]

Avoid explicit use of the case equality operator `===`.
Expand Down