Add section about Enumerable#lazy
#938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydakuka
force-pushed
the
add-enumerable-lazy
branch
3 times, most recently
from
806054e
to
cd1789d
Compare
bbatsov
reviewed
Dec 16, 2023
| @@ -4950,6 +4950,28 @@ LOREM | |||
| "when an unknown printer took a galley of type and scrambled it to make a type specimen book." | |||
| ---- | |||
|
|
|||
| == Enumerable | |||
There was a problem hiding this comment.
Might be good to check if something else can't be moved under this section as well, as it's kind of weird to have a section with a single entry in it.
bbatsov
reviewed
Dec 16, 2023
README.adoc
Outdated
| @@ -4950,6 +4950,28 @@ LOREM | |||
| "when an unknown printer took a galley of type and scrambled it to make a type specimen book." | |||
| ---- | |||
|
|
|||
| == Enumerable | |||
|
|
|||
| === lazy [[lazy]] | |||
There was a problem hiding this comment.
I'd use a more descriptive heading here - something like Leverage lazy to optimize memory usage or whatever.
bbatsov
reviewed
Dec 16, 2023
| SIZE = 10 | ||
| MAX = 10_000_000 | ||
|
|
||
| # bad |
There was a problem hiding this comment.
You might also want to mention that this will instantiate a huge collection first, so it's clearer what the problem and value proposition is.
ydakuka
force-pushed
the
add-enumerable-lazy
branch
2 times, most recently
from
e86c786
to
214df9c
Compare
ydakuka
force-pushed
the
add-enumerable-lazy
branch
from
214df9c
to
bcc9ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.