Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp is a 64-bit integer #64

Closed
carlhoerberg opened this issue May 2, 2017 · 1 comment
Closed

Timestamp is a 64-bit integer #64

carlhoerberg opened this issue May 2, 2017 · 1 comment

Comments

@carlhoerberg
Copy link
Contributor

Timestamps are encoded as 64bit integers but are here decoded as two 32 bit numbers. Normally this works well when the timestamp is a 32bit number, but not when it has millisecond precision.

At

amq-protocol/lib/amq/protocol/table_value_decoder.rb

Line 135 in dd48b32

timestamp = data.slice(offset, 8).unpack(PACK_UINT32_X2).last

instead of

timestamp = data.slice(offset, 8).unpack(PACK_UINT32_X2).last

we should do

timestamp = data.slice(offset, 8).unpack("Q>").first

And at encoding:

amq-protocol/lib/amq/pack.rb

Line 9 in c292d82

UINT64 = "Q".freeze 

UINT64 = "Q>".freeze

To do big-endian (network-endian) encoding and not platform/native endian.
@michaelklishin
Copy link
Member

@carlhoerberg thank you. Can you please submit a PR?

@carlhoerberg carlhoerberg mentioned this issue May 3, 2017
Merged
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jun 5, 2017
Update ruby-amq-protocol to 2.2.0.
08e01dc 
## Changes between 2.1.0 and 2.2.0 (unreleased)

### Timestamps are Encoded as 64-bit Unsigned Integers

This is a potentially **breaking change**. It is recommended that
all applications that use this gem and pass date/time values in message
properties or headers are upgraded at the same time.

GitHub issue: [#64](ruby-amqp/amq-protocol#64).

Contributed by Carl Hoerberg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @carlhoerberg