Run each spec file in a process to detect missing requires

* Fixes #934.

Gemfile

@@ -2,7 +2,6 @@ source 'https://rubygems.org'
 
 require File.join(File.dirname(__FILE__), 'lib/concurrent-ruby/concurrent/version')
 require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby-edge/concurrent/edge/version')
-require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby/concurrent/utility/engine')
 
 no_path = ENV['NO_PATH']
 options = no_path ? {} : { path: '.' }

README.md

@@ -271,6 +271,7 @@ Everything within this gem can be loaded simply by requiring it:
 require 'concurrent'
 ```
 
+TODO: update this
 *Requiring only specific abstractions from Concurrent Ruby is not yet supported.*
 
 To use the tools in the Edge gem it must be required separately:

concurrent-ruby.gemspec

@@ -1,5 +1,4 @@
 require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby/concurrent/version')
-require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby/concurrent/utility/engine')
 
 Gem::Specification.new do |s|
   git_files = `git ls-files`.split("\n")

deps.md

@@ -0,0 +1,13 @@
+Currently:
+* lib/concurrent-ruby/concurrent/synchronization.rb loads C exts
+* require 'concurrent/synchronization/*' seems not supported, too deep, and relies on require 'concurrent/synchronization' instead (seems OK).
+
+A cycle:
+AtomicMarkableReference -> Synchronization::Object
+
+Synchronization::Object (synchronization/object.rb) -> AtomicReference (through generated code for #initialize)
+AtomicReference -> MutexAtomicReference (but only if non-cruby-ext/non-jruby/non-truffleruby)
+MutexAtomicReference -> Synchronization::LockableObject
+Synchronization::LockableObject -> MutexLockableObject, JRubyLockableObject, MonitorLockableObject
+MutexLockableObject -> AbstractLockableObject
+AbstractLockableObject -> Synchronization::Object

docs-source/actor/format.rb

@@ -13,7 +13,7 @@
 input_paths.each_with_index do |input_path, i|
 
   pid = fork do
-    require File.join(root, 'init.rb')
+    require_relative 'init'
 
     begin
       output_path = input_path.gsub /\.in\.rb$/, '.out.rb'

docs-source/tvar.md

@@ -29,7 +29,7 @@ is first read or written. If it cannot lock a `TVar` it aborts and retries.
 There is no contention manager so competing transactions may retry eternally.
 
 ```ruby
-require 'concurrent-ruby'
+require 'concurrent'
 
 v1 = Concurrent::TVar.new(0)
 v2 = Concurrent::TVar.new(0)
@@ -60,7 +60,7 @@ However, the inconsistent reads are detected correctly at commit time. This
 means the script below will always print `[2000000, 200000]`.
 
 ```ruby
-require 'concurrent-ruby'
+require 'concurrent'
 
 v1 = Concurrent::TVar.new(0)
 v2 = Concurrent::TVar.new(0)

examples/benchmark_map.rb

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "benchmark"
-require "concurrent"
+require 'benchmark'
+require 'concurrent'
 
 hash  = {}
 map = Concurrent::Map.new

examples/format.rb

@@ -12,7 +12,7 @@
 input_paths.each_with_index do |input_path, i|
 
   pid = fork do
-    require_relative 'init.rb'
+    require_relative 'init'
 
     begin
       output_path = input_path.gsub /\.in\.rb$/, '.out.rb'

lib/concurrent-ruby-edge/concurrent/actor.rb

@@ -1,3 +1,5 @@
+# NOTE: finer grained than require 'concurrent/actor' not supported
+
 require 'concurrent/configuration'
 require 'concurrent/executor/serialized_execution'
 require 'concurrent/synchronization'

lib/concurrent-ruby-edge/concurrent/edge/cancellation.rb

@@ -1,4 +1,6 @@
 require 'concurrent/concern/deprecation'
+require 'concurrent/synchronization'
+require 'concurrent/promises'
 
 module Concurrent
 

lib/concurrent-ruby-edge/concurrent/edge/channel.rb

@@ -1,3 +1,5 @@
+require 'concurrent/synchronization/object'
+
 # @!macro warn.edge
 module Concurrent
   module Promises

lib/concurrent-ruby-edge/concurrent/edge/erlang_actor.rb

@@ -1,3 +1,11 @@
+require 'set'
+require 'concurrent/atomic/count_down_latch'
+require 'concurrent/concern/logging'
+require 'concurrent/edge/channel'
+require 'concurrent/errors'
+require 'concurrent/promises'
+require 'concurrent/synchronization/object'
+
 module Concurrent
 
   # This module provides actor abstraction that has same behaviour as Erlang actor.

lib/concurrent-ruby-edge/concurrent/edge/lock_free_queue.rb

@@ -1,3 +1,5 @@
+require 'concurrent/synchronization/object'
+
 module Concurrent
 
   # @!visibility private

lib/concurrent-ruby-edge/concurrent/edge/processing_actor.rb

@@ -1,3 +1,8 @@
+require 'concurrent/synchronization/object'
+require 'concurrent/promises'
+require 'concurrent/edge/channel'
+
+
 module Concurrent
 
   # A new implementation of actor which also simulates the process, therefore it can be used

lib/concurrent-ruby-edge/concurrent/edge/throttle.rb

@@ -1,3 +1,7 @@
+require 'concurrent/edge/lock_free_queue'
+require 'concurrent/promises'
+require 'concurrent/synchronization/object'
+
 module Concurrent
   # A tool managing concurrency level of tasks.
   # The maximum capacity is set in constructor.

lib/concurrent-ruby-edge/concurrent/executor/wrapping_executor.rb

@@ -1,3 +1,6 @@
+require 'concurrent/synchronization/object'
+require 'concurrent/executor/executor_service'
+
 module Concurrent
 
   # A delegating executor which modifies each task with arguments

lib/concurrent-ruby/concurrent/atomic/atomic_markable_reference.rb

@@ -1,3 +1,5 @@
+require 'concurrent/synchronization'
+
 module Concurrent
   # An atomic reference which maintains an object reference along with a mark bit
   # that can be updated atomically.

lib/concurrent-ruby/concurrent/atomic/event.rb

@@ -1,5 +1,5 @@
 require 'thread'
-require 'concurrent/synchronization'
+require 'concurrent/synchronization/lockable_object'
 
 module Concurrent
 

lib/concurrent-ruby/concurrent/atomic/reentrant_read_write_lock.rb

@@ -1,5 +1,6 @@
 require 'thread'
 require 'concurrent/atomic/atomic_reference'
+require 'concurrent/atomic/atomic_fixnum'
 require 'concurrent/errors'
 require 'concurrent/synchronization'
 require 'concurrent/atomic/thread_local_var'

lib/concurrent-ruby/concurrent/concern/logging.rb

@@ -20,6 +20,8 @@ def log(level, progname, message = nil, &block)
         logger = if defined?(@logger) && @logger
                    @logger
                  else
+                   # TODO this warns, need to find a better fix
+                   require 'concurrent/configuration' unless Concurrent.respond_to? :global_logger
                    Concurrent.global_logger
                  end
         logger.call level, progname, message, &block

lib/concurrent-ruby/concurrent/configuration.rb

@@ -5,6 +5,7 @@
 require 'concurrent/concern/logging'
 require 'concurrent/concern/deprecation'
 require 'concurrent/executor/immediate_executor'
+require 'concurrent/executor/fixed_thread_pool'
 require 'concurrent/executor/cached_thread_pool'
 require 'concurrent/utility/processor_counter'
 

lib/concurrent-ruby/concurrent/delay.rb

@@ -67,7 +67,7 @@ def initialize(opts = {}, &block)
 
     # Return the value this object represents after applying the options
     # specified by the `#set_deref_options` method. If the delayed operation
-    # raised an exception this method will return nil. The execption object
+    # raised an exception this method will return nil. The exception object
     # can be accessed via the `#reason` method.
     #
     # @param [Numeric] timeout the maximum number of seconds to wait

lib/concurrent-ruby/concurrent/executor/java_executor_service.rb

@@ -1,7 +1,7 @@
-if Concurrent.on_jruby?
+require 'concurrent/utility/engine'
 
+if Concurrent.on_jruby?
   require 'concurrent/errors'
-  require 'concurrent/utility/engine'
   require 'concurrent/executor/abstract_executor_service'
 
   module Concurrent

lib/concurrent-ruby/concurrent/executor/simple_executor_service.rb

@@ -1,4 +1,6 @@
-require 'concurrent/atomics'
+require 'concurrent/atomic/atomic_boolean'
+require 'concurrent/atomic/atomic_fixnum'
+require 'concurrent/atomic/event'
 require 'concurrent/executor/executor_service'
 
 module Concurrent

lib/concurrent-ruby/concurrent/ivar.rb

@@ -3,6 +3,7 @@
 require 'concurrent/collection/copy_on_write_observer_set'
 require 'concurrent/concern/obligation'
 require 'concurrent/concern/observable'
+require 'concurrent/executor/safe_task_executor'
 require 'concurrent/synchronization'
 
 module Concurrent

lib/concurrent-ruby/concurrent/promise.rb

@@ -66,7 +66,7 @@ module Concurrent
   # Start by requiring promises
   #
   # ```ruby
-  # require 'concurrent'
+  # require 'concurrent/promise'
   # ```
   #
   # Then create one

lib/concurrent-ruby/concurrent/promises.rb

@@ -2,6 +2,7 @@
 require 'concurrent/atomic/atomic_boolean'
 require 'concurrent/atomic/atomic_fixnum'
 require 'concurrent/collection/lock_free_stack'
+require 'concurrent/configuration'
 require 'concurrent/errors'
 require 'concurrent/re_include'
 

lib/concurrent-ruby/concurrent/scheduled_task.rb

@@ -57,7 +57,7 @@ module Concurrent
   #
   # @example Basic usage
   #
-  #   require 'concurrent'
+  #   require 'concurrent/scheduled_task'
   #   require 'csv'
   #   require 'open-uri'
   #

lib/concurrent-ruby/concurrent/synchronization.rb

@@ -1,20 +1,7 @@
 require 'concurrent/utility/native_extension_loader' # load native parts first
 
-require 'concurrent/utility/engine'
-
-require 'concurrent/synchronization/abstract_object'
-require 'concurrent/synchronization/mri_object'
-require 'concurrent/synchronization/jruby_object'
-require 'concurrent/synchronization/truffleruby_object'
 require 'concurrent/synchronization/object'
-require 'concurrent/synchronization/volatile'
-
-require 'concurrent/synchronization/abstract_lockable_object'
-require 'concurrent/synchronization/mutex_lockable_object'
-require 'concurrent/synchronization/jruby_lockable_object'
-
 require 'concurrent/synchronization/lockable_object'
-
 require 'concurrent/synchronization/condition'
 require 'concurrent/synchronization/lock'
 

lib/concurrent-ruby/concurrent/synchronization/abstract_lockable_object.rb

@@ -1,3 +1,6 @@
+require 'concurrent/utility/monotonic_time'
+require 'concurrent/synchronization/object'
+
 module Concurrent
   module Synchronization
 
@@ -34,7 +37,7 @@ def ns_wait_until(timeout = nil, &condition)
         if timeout
           wait_until = Concurrent.monotonic_time + timeout
           loop do
-            now              = Concurrent.monotonic_time
+            now = Concurrent.monotonic_time
             condition_result = condition.call
             return condition_result if now >= wait_until || condition_result
             ns_wait wait_until - now

lib/concurrent-ruby/concurrent/synchronization/jruby_object.rb

@@ -1,3 +1,5 @@
+require 'concurrent/utility/engine'
+
 module Concurrent
   module Synchronization
 

lib/concurrent-ruby/concurrent/synchronization/lockable_object.rb

@@ -1,3 +1,8 @@
+require 'concurrent/utility/engine'
+require 'concurrent/synchronization/abstract_lockable_object'
+require 'concurrent/synchronization/mutex_lockable_object'
+require 'concurrent/synchronization/jruby_lockable_object'
+
 module Concurrent
   module Synchronization
 

lib/concurrent-ruby/concurrent/synchronization/object.rb

@@ -1,3 +1,8 @@
+require 'concurrent/synchronization/abstract_object'
+require 'concurrent/synchronization/mri_object'
+require 'concurrent/synchronization/jruby_object'
+require 'concurrent/synchronization/truffleruby_object'
+
 require 'concurrent/synchronization/safe_initialization'
 require 'concurrent/synchronization/volatile'
 require 'concurrent/atomic/atomic_reference'

spec/concurrent/agent_spec.rb

@@ -1,3 +1,9 @@
+require 'concurrent/agent'
+require 'concurrent/executor/single_thread_executor'
+require 'concurrent/executor/immediate_executor'
+require 'concurrent/executor/fixed_thread_pool'
+require 'concurrent/atomic/count_down_latch'
+
 require_relative 'concern/observable_shared'
 
 module Concurrent

spec/concurrent/array_spec.rb

@@ -1,3 +1,5 @@
+require 'concurrent/array'
+
 module Concurrent
   RSpec.describe Array do
     let!(:ary) { described_class.new }

spec/concurrent/async_spec.rb

@@ -1,5 +1,6 @@
-module Concurrent
+require 'concurrent/async'
 
+module Concurrent
   RSpec.describe Async do
 
     let(:async_class) do

spec/concurrent/atom_spec.rb

@@ -1,4 +1,7 @@
 require_relative 'concern/observable_shared'
+require 'concurrent/atom'
+require 'concurrent/atomic/count_down_latch'
+require 'concurrent/atomic/atomic_fixnum'
 
 module Concurrent
 

spec/concurrent/atomic/atomic_boolean_spec.rb

@@ -1,3 +1,5 @@
+require 'concurrent/atomic/atomic_boolean'
+
 RSpec.shared_examples :atomic_boolean do
 
   describe 'construction' do

spec/concurrent/atomic/atomic_fixnum_spec.rb

@@ -1,3 +1,5 @@
+require 'concurrent/atomic/atomic_fixnum'
+
 RSpec.shared_examples :atomic_fixnum do
 
   context 'construction' do

spec/concurrent/atomic/atomic_markable_reference_spec.rb

@@ -1,3 +1,5 @@
+require 'concurrent/atomic/atomic_markable_reference'
+
 RSpec.describe Concurrent::AtomicMarkableReference do
   subject { described_class.new 1000, true }
 

spec/concurrent/atomic/atomic_reference_spec.rb

@@ -1,3 +1,5 @@
+require 'concurrent/atomic/atomic_reference'
+
 RSpec.shared_examples :atomic_reference do
 
   specify :test_construct do

spec/concurrent/atomic/count_down_latch_spec.rb

@@ -1,3 +1,5 @@
+require 'concurrent/atomic/count_down_latch'
+
 RSpec.shared_examples :count_down_latch do
 
   let(:latch) { described_class.new(3) }

spec/concurrent/atomic/cyclic_barrier_spec.rb

@@ -1,3 +1,7 @@
+require 'concurrent/atomic/cyclic_barrier'
+require 'concurrent/atomic/count_down_latch'
+require 'concurrent/atomic/atomic_fixnum'
+
 module Concurrent
 
   RSpec.describe CyclicBarrier do

spec/concurrent/atomic/event_spec.rb

@@ -1,3 +1,6 @@
+require 'concurrent/atomic/event'
+require 'concurrent/atomic/count_down_latch'
+
 module Concurrent
 
   RSpec.describe Event do

spec/concurrent/atomic/read_write_lock_spec.rb

@@ -1,3 +1,7 @@
+require 'concurrent/atomic/read_write_lock'
+require 'concurrent/atomic/count_down_latch'
+require 'concurrent/atomic/atomic_boolean'
+
 module Concurrent
 
   RSpec.describe ReadWriteLock do

spec/concurrent/atomic/reentrant_read_write_lock_spec.rb

@@ -1,3 +1,8 @@
+require 'concurrent/utility/engine'
+require 'concurrent/atomic/reentrant_read_write_lock'
+require 'concurrent/atomic/count_down_latch'
+require 'concurrent/atomic/atomic_boolean'
+
 unless Concurrent.on_jruby?
 
   # NOTE: These tests depend heavily on the private/undocumented