Posting to a shutdown thread pool - JRuby consistency and better naming #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects its broader scope (e.g. deciding how to handle tasks after shutdown).
|
The failing RSpec test is known to be brittle and fail intermittently. Creating behavioral test (no test doubles) around thread pools has been very challenging. |
| @@ -25,14 +25,14 @@ def initialize(num_threads, opts = {}) | |||
| super(opts) | |||
|
|
|||
|
|
|||
| #@overflow_policy = opts.fetch(:overflow_policy, :abort) | |||
| #@fallback_policy = opts.fetch(:fallback_policy, :abort) | |||
There was a problem hiding this comment.
All of these commented lines can be deleted. They are left over from a previous PR and I should have removed them earlier.
jdantonio
added a commit
that referenced
this pull request
Dec 8, 2014
Posting to a shutdown thread pool - JRuby consistency and better naming
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #199, this gives JRuby the same behaviour and renames the code to "fallback_X" rather than "overflow_X".
"rake spec" passes on JRuby 1.7.6 (which I think runs both the pure-Ruby and the Java-backed code?), and I've moved the relevant tests to be shared between all thread pool executors.