show the main object for toplevel #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViugiNick
force-pushed
the
self-inspect-fix
branch
from
c0ebfb8
to
459fb6a
Compare
valich
reviewed
Aug 3, 2017
| @@ -129,7 +129,7 @@ def execute | |||
| locals = @state.context.frame_locals(@state.frame_pos) | |||
| _self = @state.context.frame_self(@state.frame_pos) | |||
| begin | |||
| locals['self'] = _self unless "main" == _self.to_s | |||
| locals['self'] = _self | |||
There was a problem hiding this comment.
@denofevil I feel this design is OK (and compliant to what's available at runtime), please verify it's OK for you
ViugiNick
force-pushed
the
self-inspect-fix
branch
from
fd2e8d3
to
0f8c33a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can sometimes be useful, especially making the display more consistent for different classes and reduces the number of 'inspect' calls