Merge pull request #57 from drn/line-length-linter

Solve line length linter issues.

.rubocop.yml

@@ -1,2 +1,5 @@
 inherit_from: .rubocop_todo.yml
-
+AllCops:
+  Exclude:
+    - Guardfile
+    - grape-active_model_serializers.gemspec

.rubocop_todo.yml

@@ -10,9 +10,6 @@
 Metrics/AbcSize:
   Max: 20
 
-Metrics/LineLength:
-  Max: 179
-
 # Offense count: 7
 Style/Documentation:
   Enabled: false

lib/grape-active_model_serializers/endpoint_extension.rb

@@ -30,7 +30,9 @@ def self.included(base)
 
       base.class_eval do
         def serialization_scope
-          send(_serialization_scope) if _serialization_scope && respond_to?(_serialization_scope, true)
+          return unless _serialization_scope
+          return unless respond_to?(_serialization_scope, true)
+          send(_serialization_scope)
         end
       end
     end

spec/grape-active_model_serializers/endpoint_extension_spec.rb

@@ -2,9 +2,17 @@
 
 describe 'Grape::EndpointExtension' do
   if Grape::Util.const_defined?('InheritableSetting')
-    subject { Grape::Endpoint.new(Grape::Util::InheritableSetting.new, path: '/', method: 'foo') }
+    subject do
+      Grape::Endpoint.new(
+        Grape::Util::InheritableSetting.new,
+        path:   '/',
+        method: 'foo'
+      )
+    end
   else
-    subject { Grape::Endpoint.new({}, path: '/', method: 'foo') }
+    subject do
+      Grape::Endpoint.new({}, path: '/', method: 'foo')
+    end
   end
 
   let(:serializer) { Grape::Formatter::ActiveModelSerializers }
@@ -23,19 +31,29 @@ def name
     before do
       allow(subject).to receive(:env).and_return({})
     end
+
     it { should respond_to(:render) }
     let(:meta_content) { { total: 2 } }
     let(:meta_full) { { meta: meta_content } }
+
     context 'supplying meta' do
+      before do
+        allow(subject).to receive(:env) { { meta: meta_full } }
+      end
+
       it 'passes through the Resource and uses given meta settings' do
-        allow(subject).to receive(:env).and_return(meta: meta_full)
         expect(subject.render(users, meta_full)).to eq(users)
       end
     end
+
     context 'supplying meta and key' do
       let(:meta_key) { { meta_key: :custom_key_name } }
+
+      before do
+        allow(subject).to receive(:env) { { meta: meta_full.merge(meta_key) } }
+      end
+
       it 'passes through the Resource and uses given meta settings' do
-        allow(subject).to receive(:env).and_return(meta: meta_full.merge(meta_key))
         expect(subject.render(users, meta_full.merge(meta_key))).to eq(users)
       end
     end

spec/grape-active_model_serializers/formatter_spec.rb

@@ -19,18 +19,22 @@
     end
 
     it 'should read serializer options like "root"' do
-      expect(described_class.build_options_from_endpoint(app.endpoints.first)).to include :root
+      expect(
+        described_class.build_options_from_endpoint(app.endpoints.first)
+      ).to include(:root)
     end
   end
 
   describe '.fetch_serializer' do
     let(:user) { User.new(first_name: 'John') }
 
+    let(:params) { { path: '/', method: 'foo', root: false } }
     if Grape::Util.const_defined?('InheritableSetting')
-      let(:endpoint) { Grape::Endpoint.new(Grape::Util::InheritableSetting.new, path: '/', method: 'foo', root: false) }
+      let(:setting) { Grape::Util::InheritableSetting.new }
     else
-      let(:endpoint) { Grape::Endpoint.new({}, path: '/', method: 'foo', root: false) }
+      let(:setting) { {} }
     end
+    let(:endpoint) { Grape::Endpoint.new(setting, params) }
 
     let(:env) { { 'api.endpoint' => endpoint } }
 
@@ -61,7 +65,9 @@ def endpoint.default_serializer_options
     end
 
     it 'should read serializer options like "root"' do
-      expect(described_class.build_options_from_endpoint(endpoint).keys).to include :root
+      expect(
+        described_class.build_options_from_endpoint(endpoint).keys
+      ).to include(:root)
     end
   end
 end

spec/grape-active_model_serializers/versioned_api_formatter_spec.rb

@@ -15,25 +15,34 @@
 
         app.namespace('space') do |ns|
           ns.get('/', root: false, apiver: 'v1') do
-            { user: { first_name: 'JR', last_name: 'HE', email: '[email protected]' } }
+            {
+              user: {
+                first_name: 'JR',
+                last_name:  'HE',
+                email:      '[email protected]'
+              }
+            }
           end
         end
       end
 
       it 'should read serializer options like "root"' do
-        expect(described_class.build_options_from_endpoint(app.endpoints.first)).to include :root
+        expect(
+          described_class.build_options_from_endpoint(app.endpoints.first)
+        ).to include(:root)
       end
     end
 
     describe '.fetch_serializer' do
       let(:user) { User.new(first_name: 'John', email: '[email protected]') }
 
+      let(:params) { { path: '/', method: 'foo', version: 'v1', root: false } }
       if Grape::Util.const_defined?('InheritableSetting')
-        let(:endpoint) { Grape::Endpoint.new(Grape::Util::InheritableSetting.new, path: '/', method: 'foo', version: 'v1', root: false) }
+        let(:setting) { Grape::Util::InheritableSetting.new }
       else
-        let(:endpoint) { Grape::Endpoint.new({}, path: '/', method: 'foo', version: 'v1', root: false) }
+        let(:setting) { {} }
       end
-
+      let(:endpoint) { Grape::Endpoint.new(setting, params) }
       let(:env) { { 'api.endpoint' => endpoint } }
 
       before do
@@ -49,7 +58,7 @@ def endpoint.default_serializer_options
       let(:options) { described_class.build_options(user, env) }
       subject { described_class.fetch_serializer(user, options) }
 
-      let(:instance_options) { subject.instance_variable_get(:@instance_options) }
+      let(:instance_options) { subject.send(:instance_options) }
 
       it { should be_a V1::UserSerializer }
 
@@ -63,7 +72,9 @@ def endpoint.default_serializer_options
       end
 
       it 'should read serializer options like "root"' do
-        expect(described_class.build_options_from_endpoint(endpoint).keys).to include :root
+        expect(
+          described_class.build_options_from_endpoint(endpoint).keys
+        ).to include(:root)
       end
     end
   end

spec/old_grape_ams_spec.rb

@@ -31,31 +31,48 @@
     end
     it 'uses the built in grape serializer' do
       get('/home')
-      expect(subject).to eql "{\"user\":{\"first_name\":\"JR\",\"last_name\":\"HE\"}}"
+      expect(subject).to eq(
+        '{"user":{"first_name":"JR","last_name":"HE"}}'
+      )
     end
   end
 
   context "serializer isn't set" do
     before do
       app.get('/home') do
-        User.new(first_name: 'JR', last_name: 'HE', email: '[email protected]')
+        User.new(
+          first_name: 'JR',
+          last_name:  'HE',
+          email:      '[email protected]'
+        )
       end
     end
 
     it 'infers the serializer' do
       get '/home'
-      expect(subject).to eql "{\"user\":{\"first_name\":\"JR\",\"last_name\":\"HE\"}}"
+      expect(subject).to eq(
+        '{"user":{"first_name":"JR","last_name":"HE"}}'
+      )
     end
   end
 
   it 'serializes arrays of objects' do
     app.get('/users') do
-      user = User.new(first_name: 'JR', last_name: 'HE', email: '[email protected]')
+      user = User.new(
+        first_name: 'JR',
+        last_name:  'HE',
+        email:      '[email protected]'
+      )
       [user, user]
     end
 
     get '/users'
-    expect(subject).to eql "{\"users\":[{\"first_name\":\"JR\",\"last_name\":\"HE\"},{\"first_name\":\"JR\",\"last_name\":\"HE\"}]}"
+    expect(subject).to eq(
+      '{"users":['\
+        '{"first_name":"JR","last_name":"HE"},'\
+        '{"first_name":"JR","last_name":"HE"}'\
+      ']}'
+    )
   end
 
   context 'models with compound names' do
@@ -65,17 +82,29 @@
       end
 
       get '/home'
-      expect(subject).to eql "{\"blog_post\":{\"title\":\"Grape AM::S Rocks!\",\"body\":\"Really, it does.\"}}"
+      expect(subject).to eq(
+        '{"blog_post":'\
+          '{"title":"Grape AM::S Rocks!","body":"Really, it does."}'\
+        '}'
+      )
     end
 
     it "generates the proper 'root' node for serialized arrays" do
       app.get('/blog_posts') do
-        blog_post = BlogPost.new(title: 'Grape AM::S Rocks!', body: 'Really, it does.')
+        blog_post = BlogPost.new(
+          title: 'Grape AM::S Rocks!',
+          body:  'Really, it does.'
+        )
         [blog_post, blog_post]
       end
 
       get '/blog_posts'
-      expect(subject).to eql "{\"blog_posts\":[{\"title\":\"Grape AM::S Rocks!\",\"body\":\"Really, it does.\"},{\"title\":\"Grape AM::S Rocks!\",\"body\":\"Really, it does.\"}]}"
+      expect(subject).to eq(
+        '{"blog_posts":['\
+          '{"title":"Grape AM::S Rocks!","body":"Really, it does."},'\
+          '{"title":"Grape AM::S Rocks!","body":"Really, it does."}'\
+        ']}'
+      )
     end
   end
 
@@ -87,7 +116,9 @@
     end
 
     get '/admin/jeff'
-    expect(subject).to eql "{\"user\":{\"first_name\":\"Jeff\",\"last_name\":null}}"
+    expect(subject).to eq(
+      '{"user":{"first_name":"Jeff","last_name":null}}'
+    )
   end
 
   context 'route is in a namespace' do
@@ -100,7 +131,12 @@
       end
 
       get '/admin/jeff'
-      expect(subject).to eql "{\"admin\":[{\"first_name\":\"Jeff\",\"last_name\":null},{\"first_name\":\"Jeff\",\"last_name\":null}]}"
+      expect(subject).to eq(
+        '{"admin":['\
+          '{"first_name":"Jeff","last_name":null},'\
+          '{"first_name":"Jeff","last_name":null}'\
+        ']}'
+      )
     end
   end
 
@@ -112,7 +148,12 @@
       end
 
       get '/people'
-      expect(subject).to eql "{\"people\":[{\"first_name\":\"Jeff\",\"last_name\":null},{\"first_name\":\"Jeff\",\"last_name\":null}]}"
+      expect(subject).to eq(
+        '{"people":['\
+          '{"first_name":"Jeff","last_name":null},'\
+          '{"first_name":"Jeff","last_name":null}'\
+        ']}'
+      )
     end
   end
 end