Grape::ActiveModelSerializers for models with compound names

[george]

Grape::ActiveModelSerializers for models with compound names
  should generate the proper 'root' node for individual objects
  should generate the proper 'root' node for serialized arrays of objects

Just changed #downcase to #underscore in lib/grape-active_model_serializers/formatter.rb

And thanks for the library. Much appreciated!

[jrhe]

Oh gosh, someone is actually using this. I haven't quite finished it
(arrays are totally broken) but I will merge this change in for now. Thank
you!

On 30 April 2013 19:24, George Anderson [email protected] wrote:

Grape::ActiveModelSerializers for models with compound names
should generate the proper 'root' node for individual objects
should generate the proper 'root' node for serialized arrays of objects

Just changed #downcase to #underscore in
lib/grape-active_model_serializers/formatter.rb

And thanks for the library. Much appreciated!

You can merge this Pull Request by running

git pull https://github.com/george/grape-active_model_serializers proper_root_node_for_compound_model_names

Or view, comment on, or merge it at:

#1
Commit Summary

• Grape::ActiveModelSerializers for models with compound names

File Changes

• M lib/grape-active_model_serializers/formatter.rbhttps://github.com/Grape::ActiveModelSerializers for models with compound names #1/files#diff-0(4)
• M spec/db/schema.rbhttps://github.com/Grape::ActiveModelSerializers for models with compound names #1/files#diff-1(10)
• M spec/grape_ams_spec.rbhttps://github.com/Grape::ActiveModelSerializers for models with compound names #1/files#diff-2(21)
• M spec/spec_fakes.rbhttps://github.com/Grape::ActiveModelSerializers for models with compound names #1/files#diff-3(10)

Patch Links:

• https://github.com/jrhe/grape-active_model_serializers/pull/1.patch
• https://github.com/jrhe/grape-active_model_serializers/pull/1.diff

[george]

Arrays appear to be working for me, though I'm just getting started with my API implementation. What's not working? Perhaps I could work on it a bit.

Thanks again.

[jrhe]

Maybe I pushed the changes to add array support. I will have a look back through the code. I just remember something important needed doing then life got in the way.

[george]

Understood. Ping me if I can do anything. And thanks for your code.

On Tue, Apr 30, 2013 at 4:14 PM, jrhe [email protected] wrote:

Maybe I pushed the changes to add array support. I will have a look back
through the code. I just remember something important needed doing then
life got in the way.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-17251334
.