Should not allow noop arguments for I18n.t
#545
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related ruby-i18n#501, ruby-i18n#500, and ruby-i18n#471. In Ruby 3.0, the behavior of `I18n.t("key", { value: "foo" })` has silently changed to `{ value: "foo" }` is no longer regarded as `**options` but regarded as noop slpat arguments `*`. https://github.com/ruby-i18n/i18n/blob/4709391dceab9096d5988576f93935843023a6ef/lib/i18n.rb#L195 So allowing (discarding) noop arguments will be more harmful in Ruby 3.0. This removes the allowing noop arguments, it makes `{ value: "foo" }` will raise ArgumentError instead of silently ignored the options.
radar
force-pushed
the
should_not_allow_noop_arguments
branch
from
e66613e
to
c4dfcda
Compare
|
Updated to the latest master to ensure that this PR has checks ran for Ruby 3 + Rails 6.1. The code looks good to me. Let's see what CI says. |
|
CI's happy. Let's go. |
ChrisBAshton
added a commit
to alphagov/collections
that referenced
this pull request
Jan 13, 2021
A change was introduced in v1.8.6 to support a change in behaviour in Ruby 3: ruby-i18n/i18n#545 > In Ruby 3.0, the behavior of `I18n.t("key", { value: "foo" })` has > silently changed to `{ value: "foo" }` is no longer regarded as > `**options` but regarded as noop slpat arguments `*`. As such, we have to change our calls to `I18n.t` to take 2 args rather than 3. This immediately causes an issue whereby if you pass a count of 2 and no pluralization data, it raises a `I18n::InvalidPluralizationData`, so we've had to catch that and set the response to `nil`, which appears to be the behaviour we were expecting prior.
Wynndow
added a commit
to alphagov/verify-frontend
that referenced
this pull request
Mar 3, 2021
We've bumped the version of the `i18n` module from 1.8.5 to 1.8.9. Version [1.8.6](https://github.com/ruby-i18n/i18n/releases/tag/v1.8.6) introduced a change to the parameters for the `translate` method. It removed the `*` operator, which allows any number of args to be passed in. These args were just discarded. You can see the change to the source here: ruby-i18n/i18n#545 We were passing in an extra arg in a couple of places in our tests. This removes them and prevents an `ArgumentError` being thrown.
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #501, #500, and #471.
In Ruby 3.0, the behavior of
I18n.t("key", { value: "foo" })hassilently changed to
{ value: "foo" }is no longer regarded as**optionsbut regarded as noop slpat arguments*.i18n/lib/i18n.rb
Line 195 in 4709391
So allowing (discarding) noop arguments will be more harmful in Ruby 3.0.
This removes the allowing noop arguments, it makes
{ value: "foo" }will raise ArgumentError instead of silently ignored the options.