Revert #503 changes for Backend::Base
#637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
changed the title
Backend::BaseBackend::Base
|
@movermeyer Please rebase. |
See ruby-i18n#635 for discussion
movermeyer
force-pushed
the
movermeyer/nested_pluralization_with_base_backend
branch
from
4c5687e
to
cda0ea5
Compare
movermeyer
changed the title
Backend::BaseBackend::Base
@radar 👍 Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #514. See #635 for discussion of how this situation came to be.
What approach did you choose and why?
Simply a revert of the changes to
Backend::Basein #503, similar to the revert done forBackend::Pluralizationin 1b5e345.The impact of these changes
Keys nested within pluralization contexts will once again work for those using
Backend::Base