Simplify the "Translation missing" message when default is an empty Array #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This seemingly innocuous change is causing us issues as well. Please reach out if you have any questions Thanks for the great Gem |
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
Jun 2, 2023
There is an issue with 1.14 that breaks tests, and possibly functionality, too. Within 3 hours a number of people have referenced this issue so we are not alone This is fixed by ruby-i18n/i18n#662
4 tasks
|
@kbrock please test this PR against your code and let me know if that solved your issue. I’ll merge to master now. |
radar
approved these changes
Jun 2, 2023
|
I have released i18n 1.14.1 with this change included. |
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
There is an issue with 1.14 that breaks tests, and possibly functionality, too. Within 3 hours a number of people have referenced this issue so we are not alone This is fixed by ruby-i18n/i18n#662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#654 changed the "Tranlation missing" message to show all the potential keys when an Array was given for
:default, but this enhancement is not necessary if the:defaultArray was an empty Array.Giving an empty Array for
:defaultis actually done inside Action View translation helper: https://github.com/rails/rails/blob/254f1d8ded07dfd73462b40d6aaa8c19032259f6/actionview/lib/action_view/helpers/translation_helper.rb#L125and so this causes this build error there in Rails repo. https://buildkite.com/rails/rails/builds/96893#01887b39-855d-4c78-a6ac-0c90889025fd