Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net::LDAP#open does not cache bind result #331

Closed
wants to merge 5 commits into from
Closed

Net::LDAP#open does not cache bind result #331

wants to merge 5 commits into from

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Nov 12, 2019 •
edited
Loading

We identified that clients cannot safely rely on Net::LDAP#get_operation_result when using Net::LDAP#open because @result is not set.

As a consequence, clients calling Net::LDAP#get_operation_result would get the previous cached @result. Yikes.

@vroldanbet
demonstrates Net::LDAP#open does not expose bind results
b268cf3 
we identified that clients cannot safely rely on
Net::LDAP#get_operation_result when using Net::LDAP#open
because @Result is not set.

As a consequence,clients calling
Net::LDAP#get_operation_result would get the previous
last cached result @Result.
@vroldanbet
ignore RubyMine metadata
6c929d2
@vroldanbet
attempt to fix broken "install-openldap" in travis
8135bbe 
may have broken in the most recent slapd version for Ubuntu Xenial?
@vroldanbet
caches bind result
cb4b48c 
aligns implementation of open with other methods, so the result
becomes accessible via get_operation_result
@vroldanbet
the test environment expects a valid DNS as username
dd2a880
@vroldanbet
Copy link
Contributor Author

vroldanbet commented Nov 12, 2019 •
edited
Loading

In 8135bbe we can see the 🐛 manifesting. It expected code 49 (invalid creds) but instead got 0.

In dd2a880 the test goes green after introducing the fix in cb4b48c

Unfortunately CI is broken. I tried to address it, but it seems TLS configuration is not being set properly, and so TLS integration tests are failing 😭

@vroldanbet
Copy link
Contributor Author

I'm addressing CI build in #333

@vroldanbet vroldanbet mentioned this pull request Nov 15, 2019
Merged
@vroldanbet
Copy link
Contributor Author

Superseded by #334, which contains the fixed CI build

@vroldanbet vroldanbet closed this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vroldanbet