Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build #333

Merged
merged 30 commits into from
Nov 16, 2019
Merged

Fix CI build #333

merged 30 commits into from
Nov 16, 2019

Commits on Nov 14, 2019

  1. docker openldap server

    instead of polluting devs machine, let's rely on a docker container
    to spin up the service
    
    relies on osixia/openldap:1.3.0. Customizes a few things:
    - adds the seed on bootstrap
    - does not enforce client certificate
    - sets a hostname to avoid domain verification issues during handshake
    
    The cert domain is also added to /etc/hosts
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    c3f0e4c View commit details
    Browse the repository at this point in the history
  2. clarify why we need it

    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    fdbe61e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddd8dce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3caf85b View commit details
    Browse the repository at this point in the history
  5. change test DSN and authenticate with the right user

    anonymous access is not enabled in this setup, so every test needs
    to perform authentication first
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    683d660 View commit details
    Browse the repository at this point in the history
  6. adjust hostname to the new certificate for TLS tests

    I couldn't manage to get the container running with a cert
    issued to a given IP, like 127.0.0.1 or localhost.
    Instead, I specified a static hostname
    (the container uses hostname to generate the cert)
    and injected it in travis.
    
    Unfortunately, in local development this means changing /etc/hosts,
    but I feel that's a better option that having to install LDAP locally
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    fb4c76d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    94c2ba9 View commit details
    Browse the repository at this point in the history
  8. adds custom retcode.ldif to the bootstrap sequence

    so that all retcode tests succeed
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4280d18 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f38c39c View commit details
    Browse the repository at this point in the history
  10. let's assume folks will have to modify /etc/hosts

    it's a little price to pay in the current setup and allows us to
    have the same tests locally and dev.
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    1b595b2 View commit details
    Browse the repository at this point in the history
  11. we don't need vagrant specific tests anymore

    all environments run the same set of tests, no env specific test
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ba225a9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    376c42e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    839318a View commit details
    Browse the repository at this point in the history
  14. installs docker container CA certificate

    so that we are able to run a test that does not specific CACERT
    and so the library fallsback to system cert store
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    9b8d80d View commit details
    Browse the repository at this point in the history
  15. let's disable the test that uses system cert store

    I'm not sure how to enable this in Travis
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7c85643 View commit details
    Browse the repository at this point in the history
  16. remove unused stuff

    with the dockerized test openldap server, none of this is needed
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6c1c56d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f67e741 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5c4644e View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    10a44d5 View commit details
    Browse the repository at this point in the history
  20. update documentation

    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8ba87b3 View commit details
    Browse the repository at this point in the history
  21. clarify /etc/hosts caveat, needed for local integration tests

    the container uses HOSTNAME to generate the cert, and
    it really didn't like "localhost" as hostname.
    
    As a workaround, I had to add an arbitrary hostname. There may be other
    alternatives to get the host to be known, but the most obvious
    is modifying /etc/hosts
    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    201fdfa View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    dc6d75d View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    fee04d8 View commit details
    Browse the repository at this point in the history
  24. what about this

    vroldanbet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    fef7cdb View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    cf4e9bd View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. format the snippet as code

    Co-Authored-By: Matt Todd <[email protected]>
    vroldanbet and mtodd authored Nov 15, 2019
    Configuration menu
    Copy the full SHA
    35bcc92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b90ee7e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9228e2 View commit details
    Browse the repository at this point in the history
  4. ignore RubyMine metadata

    vroldanbet committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    14dfc2a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    693b210 View commit details
    Browse the repository at this point in the history