Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raptor_world arg to FFI definition for func raptor_free_world (instead of no args) #28

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

emgullufsen-lii
Copy link
Contributor

@emgullufsen-lii emgullufsen-lii commented Sep 27, 2024

The underlying c library seems to accept a pointer to a raptor_world object, whereas the FFI defines no args to this function.

Here is the library definition:
https://github.com/dajobe/raptor/blob/e4285aefef442da7e4e847dfd77097a40506773f/src/raptor2.h.in#L1051

void raptor_free_world(raptor_world* world);

But here we have no args defined:

attach_function :raptor_free_world, [], :void

Please see this issue for more detailed explanation:
#27

Fixes #27.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

@emgullufsen-lii emgullufsen-lii changed the title raptor_world arg to raptor_free_world (instead of no args) Add raptor_world arg to FFI definition for func raptor_free_world (instead of no args) Sep 27, 2024
@coveralls
Copy link

Coverage Status

coverage: 79.315%. remained the same
when pulling fef3343 on emgullufsen-lii:develop
into 76411d5 on ruby-rdf:develop.

@gkellogg gkellogg added the bug label Sep 28, 2024
@gkellogg
Copy link
Member

Thanks!

@gkellogg gkellogg merged commit 6392cea into ruby-rdf:develop Sep 28, 2024
6 checks passed
@emgullufsen-lii
Copy link
Contributor Author

Thanks for the gem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI (V2) has incorrect args for raptor_free_world?
4 participants