Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ericgpks as a reviewer to some rails dependency gems #611

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

ericgpks
Copy link
Contributor

By reading this issue #558, I would like to join as a reviewer in some gems.
I add me as a reviewer in this PR.

Copy link

@ericgpks Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

aws-sdk-s3

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


slack-notifier

You changed RBS files for an existing gem.
This gem does not have reviewers. So you can merge this PR immediately if the CI passes.
We recommend you add yourself to the reviewers for this gem.

@ksss
Copy link
Collaborator

ksss commented Jun 21, 2024

@ericgpks
Thank you for expressing your intention.
However, I am sorry, but I am considering removing the aws-sdk gem from gem_rbs_collection. (I haven't deleted it yet because I haven't been able to verify what will happen if it's removed.)
Even if you are added as a reviewer, your first task will likely be to review the removal.

ref: #511

@ericgpks
Copy link
Contributor Author

@ksss
Thank you for sharing the situation. I got it.

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

Thanks for your review, @ksss!

@ericgpks, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@ericgpks
Copy link
Contributor Author

/merge

@github-actions github-actions bot merged commit ea1342a into ruby:main Jun 25, 2024
5 checks passed
@ericgpks ericgpks deleted the addme branch August 22, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants