Stringify when a non-object is passed to PP#text #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aycabta
force-pushed
the
stringify-when-a-non-object-is-passed-to-pp-text
branch
3 times, most recently
from
8804d93
to
1a60403
Compare
k0kubun
reviewed
Jan 4, 2021
k0kubun
reviewed
Jan 4, 2021
If a nested object is passed to #pp, it may be sometimes passed to the #text method as an object without being stringified. This is fixed on the Ruby main repository; ruby/ruby@433a3be but it was a bug of Ripper so still needs this workaround for using irb as a gem on Ruby 3.0.0 or earlier. Co-authored-by: k0kubun <[email protected]>
aycabta
force-pushed
the
stringify-when-a-non-object-is-passed-to-pp-text
branch
from
1a60403
to
8d13df2
Compare
|
Fixed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a nested object is passed to
#pp, it may be sometimes passed to the#textmethod as an object without being stringified.This is fixed on the Ruby main repository, but it was a bug of Ripper so still needs this workaround for using irb as a gem on Ruby 3.0.0 or earlier.