Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using Reline as a module #633

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Avoid using Reline as a module #633

merged 1 commit into from
Jul 9, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 8, 2023

Using it as a module makes it harder to understand methods' source.

@st0012
Avoid using Reline as a module
e39cd8d 
Using it as a module makes it harder to understand methods' source.
@st0012 st0012 requested a review from a team July 8, 2023 21:26
ima1zumi
ima1zumi approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@ima1zumi ima1zumi merged commit 652f413 into master Jul 9, 2023
@ima1zumi ima1zumi deleted the call-reline-methods-directly branch July 9, 2023 06:24
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 9, 2023
@st0012 @matzbot
[ruby/irb] Avoid using Reline as a module
4e2f98b 
(ruby/irb#633)

Using it as a module makes it harder to understand methods' source.
@st0012 st0012 mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @ima1zumi