Extract integration testing helpers out of debug command tests #660
Conversation
st0012
force-pushed
the
integration-test-case
branch
from
3626ca0
to
69783b4
Compare
| @ruby_file = Tempfile.create(%w{irb- .rb}) | ||
| @ruby_file.write(program) | ||
| @ruby_file.close | ||
| end |
There was a problem hiding this comment.
Just an idea
I know that this code is not changed from test_debug_cmd.rb, but could it be like this?
ruby_code = <<~RUBY
foo
binding.irb
bar
RUBY
run_ruby_file ruby_code do endThis helper will going to be used in several test, so it's a good opportunity to change it.
write_ruby was introduced in 976100c.
In that point, defining write_ruby like another existing method write_irbrc makes sense because it's optional. Not always used.
Now, write_ruby is always used before run_ruby_file. I think passing as an argument is more simple.
Although, my idea has a weak point. Must think how to do something like
assert_match(/Object#foo at #{@ruby_file.to_path}/, output)
There was a problem hiding this comment.
I agree with the direction, but I feel we can design the API better after seeing other use cases. Can we revisit this after we applied integration for #659's fix?
The ability to run a test case in a subprocess is useful for testing many other features, like nested IRB sessions. So I think it's worth extracting them into a new test case class.
st0012
force-pushed
the
integration-test-case
branch
from
69783b4
to
134de58
Compare
tests (ruby/irb#660) The ability to run a test case in a subprocess is useful for testing many other features, like nested IRB sessions. So I think it's worth extracting them into a new test case class. ruby/irb@73b7a895f8
The ability to run a test case in a subprocess is useful for testing many other features, like nested IRB sessions. So I think it's worth extracting them into a new test case class.
For example, I'll need it for #659