Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print deprecation message for prompt_n methods #691

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 22, 2023

They were removed in #685, but we should still keep them to avoid breaking changes to tools like Chef.

https://github.com/chef/chef/blob/533ff089479763f29045e4e6ddf388b73fc99338/lib/chef/shell.rb#L138

@st0012 st0012 requested a review from a team August 22, 2023 17:57
@st0012 st0012 self-assigned this Aug 22, 2023
@tompng tompng merged commit b585e0c into master Aug 23, 2023
47 checks passed
@tompng tompng deleted the warn-prompt-n-removal branch August 23, 2023 15:37
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants