Fix deprecation test when ran multiple times #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecation warning is only printed on the first time the test is ran, so subsequent runs will fail because the error message will not be printed. This can be seen in the Ruby CI logs such as http://ci.rvm.jp/results/trunk-repeat50@ruby-sp2-docker/4696313: 1) Failure: TestIRB::RubyLexTest#test_initialising_the_old_top_level_ruby_lex [/tmp/ruby/src/trunk-repeat50/test/irb/test_ruby_lex.rb:210]: Expected /warning: constant ::RubyLex is deprecated/ to match "". It can also be reproduced in the Ruby repo with the following test command: make test/irb/test_ruby_lex.rb TESTOPTS=--repeat-count=2 This commit changes the test to use assert_in_out_err, which spawns a new Ruby process.
st0012
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warning is only printed on the first time the test is ran, so subsequent runs will fail because the error message will not be printed. This can be seen in the Ruby CI logs such as http://ci.rvm.jp/results/trunk-repeat50@ruby-sp2-docker/4696313:
It can also be reproduced in the Ruby repo with the following test command:
This commit changes the test to use assert_in_out_err, which spawns a new Ruby process.