Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test should not depend on user's irbrc file #714

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Test should not depend on user's irbrc file #714

merged 1 commit into from
Sep 16, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 16, 2023

Fixes #713
Many test was failing in local environment If user's irbrc file is:

# $HOME/.irbrc
exit

or

# $XDG_CONFIG_HOME/irb/irbrc
exit

Some other settings (example: IRB.conf[:PROMPT_MODE] = :FOOBAR) was also making test fail.

@st0012 st0012 merged commit 02703c4 into ruby:master Sep 16, 2023
24 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Sep 16, 2023
@tompng @matzbot
[ruby/irb] Test should not depend on user's irbrc file
cd67c0d 
(ruby/irb#714)

ruby/irb@02703c46f9
@chadrschroeder chadrschroeder mentioned this pull request Sep 17, 2023
Closed
@tompng tompng mentioned this pull request Sep 17, 2023
Merged
@tompng tompng deleted the test_with_empty_home branch May 3, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local Test Errors Differ Depending on Testing User's :PROMPT_MODE in .irbrc
2 participants
@tompng @st0012