Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdoc version lock is required #897

Merged
merged 1 commit into from
Mar 8, 2024
Merged

rdoc version lock is required #897

merged 1 commit into from
Mar 8, 2024

Commits on Mar 8, 2024

  1. rdoc version lock is required

    Some features of irb do not work properly when using the old rdoc.
    I have compared several major versions and found that it works as intended from 4.0.0.
    
    This problem occurs when there is a Gemfile.lock is installed with the old rdoc.
    I don't know why this Gemfile.lock installs an older rdoc than the ruby bundled rdoc,
    but specifying the version in the gemspec will at least prevent the problem.
    
    NOTE: ruby#704 problem does not occur with this change.
    
    The following is test code.
    
    ```
     ### Usage: ruby __FILE__.rb
     # # input RDoc and Tab
     # >> RDoc<Tab>
     #
     ### Expect: Display document of RDoc
     ### Actual: <internal:marshal>:34:in `load': instance of RDoc::Constant needs to have method `marshal_load' (TypeError)
    require "bundler/inline"
    
    gemfile(true) do
      source "https://rubygems.org"
    
      git_source(:github) { |repo| "https://github.com/#{repo}.git" }
      gem 'irb'
      # gem 'rdoc', '~> 4.0.0'
      gem 'rdoc', '~> 3.12.0'
    end
    
    require 'rdoc'
    require 'irb'
    
    IRB.start
    ```
    alpaca-tc committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    aebf608 View commit details
    Browse the repository at this point in the history