Pass statements to Context#evaluate #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a few benefits: - We can keep hiding the evaluation logic inside the Context level, which has always been the convention until #824 was merged recently. - Although not an official API, gems like `debug` and `mission_control-jobs` patch `Context#evaluate` to wrap their own logic around it. This implicit contract was broken after #824, and this change restores it. In addition to the refactor, I also converted some context-level evaluation tests into integration tests, which are more robust and easier to maintain.
st0012
commented
Apr 11, 2024
| # We also need to have a way to restart/stop threads around command execution | ||
| # when being used as `debug`'s console. | ||
| # https://github.com/ruby/debug/blob/master/lib/debug/irb_integration.rb#L8-L13 | ||
| puts "INTERNAL_INFO: {}" if @context.with_debugger && ENV['RUBY_DEBUG_TEST_UI'] == 'terminal' |
There was a problem hiding this comment.
We won't need this workaround with this change because the current debug patch will be applied to command execution too.
tompng
approved these changes
Apr 12, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 12, 2024
(ruby/irb#920) This has a few benefits: - We can keep hiding the evaluation logic inside the Context level, which has always been the convention until #824 was merged recently. - Although not an official API, gems like `debug` and `mission_control-jobs` patch `Context#evaluate` to wrap their own logic around it. This implicit contract was broken after #824, and this change restores it. In addition to the refactor, I also converted some context-level evaluation tests into integration tests, which are more robust and easier to maintain. ruby/irb@b32aee4068
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
(ruby/irb#920) This has a few benefits: - We can keep hiding the evaluation logic inside the Context level, which has always been the convention until ruby#824 was merged recently. - Although not an official API, gems like `debug` and `mission_control-jobs` patch `Context#evaluate` to wrap their own logic around it. This implicit contract was broken after ruby#824, and this change restores it. In addition to the refactor, I also converted some context-level evaluation tests into integration tests, which are more robust and easier to maintain. ruby/irb@b32aee4068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few benefits:
debugandmission_control-jobspatchContext#evaluateto wrap their own logic around it. This implicit contract was broken after Move away from method-based command implementation #824, and this change restores it.In addition to the refactor, I also converted some context-level evaluation tests into integration tests, which are more robust and easier to maintain.