Merge pull request #1153 from flavorjones/flavorjones-fix-gem-git-sou…

…rce-usage extconf.rb: using "sh" when unnecessary won't work on some systems
ruby · Jul 19, 2023 · 728dd07 · 728dd07
2 parents a5fa477 + e1e5156
commit 728dd07
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/ext/yarp/extconf.rb b/ext/yarp/extconf.rb
@@ -61,11 +61,11 @@ def build_target_rubyparser(target)
           if !File.exist?("configure") && Dir.exist?(".git")
             # this block only exists to support building the gem from a "git" source,
             # normally we package up the configure and other files in the gem itself
-            Rake.sh("sh", "autoconf")
-            Rake.sh("sh", "autoheader")
-            Rake.sh("rake","templates")
+            Rake.sh("autoconf")
+            Rake.sh("autoheader")
+            Rake.sh("rake", "templates")
           end
-          Rake.sh("sh", "configure")
+          Rake.sh("sh", "configure") # explicit "sh" for Windows where shebangs are not supported
           Rake.sh("make", target)
         end
       end