Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serialization for snapshots #1049

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Use serialization for snapshots #1049

merged 2 commits into from
Jun 22, 2023

Conversation

kddnewton
Copy link
Collaborator

@kddnewton kddnewton commented Jun 22, 2023

This gets rid of the LANG issue and makes it so that we don't have to deal with encoding problems.

To get the nicer snapshot diffs, run:

git config diff.snapshot.textconv bin/deserialize
git config diff.snapshot.binary true

Copy link
Collaborator

@jemmaissroff jemmaissroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing we could do is make a helper script to get nicer git diffs. But since it's only two lines, definitely don't think that's necessary

@kddnewton
Copy link
Collaborator Author

Yeah I was thinking it might be good to have a bin/setup script for installing dependencies and other stuff. We could add this stuff to that.

@kddnewton kddnewton merged commit 1f2f88d into main Jun 22, 2023
@kddnewton kddnewton deleted the use-serialization branch June 22, 2023 19:08
@eregon
Copy link
Member

eregon commented Jun 23, 2023

This means it's no longer possible to review the snapshots diff on GitHub.
What's this LANG issue? Wouldn't it be enough to dump the snapshots as UTF-8 or binary to solve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants