Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up the gemspec and the manifest check #1145

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix up the gemspec and the manifest check #1145

merged 1 commit into from
Jul 18, 2023

Conversation

flavorjones
Copy link
Contributor

@flavorjones
Fix up the gemspec and the manifest check
f4b6c24 
- ignore lib/yarp.bundle
- :check_manifest task is a dependency of :test
- remove yp_snprintf.c from the gemspec (see 4793b1c / ruby#962)
jemmaissroff
jemmaissroff approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@jemmaissroff jemmaissroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jemmaissroff jemmaissroff merged commit 29086ab into ruby:main Jul 18, 2023
20 checks passed
@flavorjones flavorjones deleted the flavorjones-fix-gemspec-20230718 branch July 19, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemmaissroff jemmaissroff jemmaissroff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flavorjones @jemmaissroff