Implement emoji support #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2021 13:23
|
Fixes #371 and glebm/i18n-tasks#291 ? |
|
It should! We can add some more tests to ensure that it works for the most commonly used Unicode characters |
|
Seems to break CI 😅. I really like the idea of supporting emoji, but I'm somewhat worried about supporting effectively a fork of libyaml. But I really do like the idea of supporting emoji 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with 4 byte unicode characters. It uses code from a pr which was filed against tarantool in response to tarantool/tarantool#4090.
I'm well aware that this probably should belong to the libyaml repository. I wanted to open it here first to have a base to work from. Response time in libyaml seems to be somewhat long and thus I think this is a feature we should implement asp. This could unlock faster automated translations in Rails(as I18n hands over yaml generation to this gem).