FileTask#out_of_date? calls depended FileTask#out_of_date? for execution #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,14 @@ def timestamp | |||
|
|
|||
| # Are there any prerequisites with a later time than the given time stamp? | |||
| def out_of_date?(stamp) | |||
| @prerequisites.any? { |n| application[n, @scope].timestamp > stamp } | |||
| @prerequisites.any? { |p| | |||
There was a problem hiding this comment.
p is a name which is in Ruby as Kernel#p. Can you find a good replacement name for the block parameter?
There was a problem hiding this comment.
Oh, I made a silly mistake. It's as you says. I added a commit 679ccb8.
aycabta
force-pushed
the
file-dryrun-bug-92
branch
from
13e16c1
to
679ccb8
Compare
aycabta
force-pushed
the
file-dryrun-bug-92
branch
from
0c712c0
to
ec7dc8f
Compare
aycabta
force-pushed
the
file-dryrun-bug-92
branch
from
ec7dc8f
to
7be2c78
Compare
1 similar comment
| rake "-n" | ||
| assert_equal(%w{fileA fileB fileC default}, dryrun_tasks) | ||
| rake | ||
| sleep 1 # for stride seconds surely for timestamp |
There was a problem hiding this comment.
Just a passer-by reading this comment. I'm confused by it. Can you reword it, to make it less ambiguous?
What I believe it wants to say: Ensure the timestamp is on a new second.
There was a problem hiding this comment.
Thanks, I added a commit to fix the comment!
hsbt
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #92 what says below:
I think so. In this Pull Request,
FileTask#out_of_date?calls dependencyFileTask's#out_of_date?viaFileTask#needed?.