Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve <summary> CSS on sidebar #1012

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented May 26, 2023

  • Use a smaller font size for the toggle symbol. (Currently, it seems a little too large)
  • Use the child combinator (>) to unify selectors.
  • Use margin-left instead of whitespace within the content property.
  • Use :: instead of outdated : for the pseudo-element symbol. (See https://developer.mozilla.org/en-US/docs/Web/CSS/::before)

Examples with Chrome 113:

Before After
image image
image image

Ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/summary

Note: Please feel free to close this PR if you disagree (since it reflects my preference).

- Use a smaller font size for the toggle symbol. (Currently, it seems a little too large)
- Use the child combinator (`>`) to unify selectors.
- Use `margin-left` instead of whitespace within the `content` property.
- Use `::` instead of outdated `:` for the pseudo-element symbol.
  (See https://developer.mozilla.org/en-US/docs/Web/CSS/::before)
@ybiquitous ybiquitous marked this pull request as ready for review May 26, 2023 14:12
@nobu nobu merged commit 61ce0a7 into ruby:master May 26, 2023
@ybiquitous ybiquitous deleted the improve-sidebar-css branch May 26, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants