Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve layout CSS #1013

Merged
merged 1 commit into from
May 26, 2023
Merged

Improve layout CSS #1013

merged 1 commit into from
May 26, 2023

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented May 26, 2023 •
edited
Loading

Note that all modern browsers support the new CSS properties and functions used by this change.

Before After
Screenshot 2023-05-27 at 0 41 17 Screenshot 2023-05-27 at 0 41 29

Resizable (resize):

Screenshot 2023-05-27 at 0 42 52

@ybiquitous
Improve layout CSS
cb4ca13 
- Use the `grid` property for the page layout.
  - https://caniuse.com/css-grid
- Adjust the `<main>` margin.
- Make the sidebar responsive and resizable.
  - https://caniuse.com/css-math-functions
  - https://caniuse.com/css-resize

Note all modern browsers support the new CSS properties and functions used by this change.
@ybiquitous ybiquitous marked this pull request as ready for review May 26, 2023 15:31
@nobu nobu merged commit 2db5097 into ruby:master May 26, 2023
@ybiquitous ybiquitous deleted the improve-layout-css branch May 26, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybiquitous @nobu