Delay DidYouMean until NotFoundError#message is called #1039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expand_class
is slow for long class name that has no document.It's because did_you_mean is slow and always calculated before raising NotFoundError.
This pull request delays calculation of DidYouMean until
NotFoundError#message
is called.Processing time reduces
0.227079s → 0.006436s
Background
This will fix ruby/irb#709