Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue caused by using repeated > characters inside comments #171

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Watson1978
Copy link
Contributor

A < is treated as a string delimiter.
In certain cases, if < is used in succession, read and match are repeated, which slows down the process. Therefore, the following is used to read ahead to a specific part of the string in advance.

…comments

A `<` is treated as a string delimiter. 
In certain cases, if `<` is used in succession, read and match are repeated, which slows down the process.
Therefore, the following is used to read ahead to a specific part of the string in advance.
test/parse/test_comment.rb Outdated Show resolved Hide resolved
@kou kou merged commit c1b64c1 into ruby:master Jul 16, 2024
61 checks passed
@kou
Copy link
Member

kou commented Jul 16, 2024

Thanks.

@Watson1978 Watson1978 deleted the fix-performance-2 branch July 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants