nested exception tests for discussion #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjb
force-pushed
the
test-nested-exception-identity
branch
from
771c0ca
to
7ae36a8
Compare
jjb
force-pushed
the
test-nested-exception-identity
branch
from
7ae36a8
to
3e42aa4
Compare
eregon
reviewed
Nov 7, 2023
| raised_exception = e | ||
| end | ||
|
|
||
| assert_equal 'inner message', e.message |
There was a problem hiding this comment.
e.message -> raised_exception.message
There was a problem hiding this comment.
thanks @eregon - are you saying that that is the more important thing to test?
There was a problem hiding this comment.
added the additional check https://github.com/ruby/timeout/pull/43/files
|
Yeah, this is the current and what looks to be the correct behavior, so good to be merged. |
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion in #38