Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback missing constants with RFC3986_PARSER #113

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Fallback missing constants with RFC3986_PARSER #113

merged 5 commits into from
Aug 6, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Aug 6, 2024

byroot
byroot approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@byroot byroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

nobu
nobu reviewed Aug 6, 2024
View reviewed changes
test/uri/test_common.rb Show resolved Hide resolved
lib/uri/common.rb Outdated Show resolved Hide resolved
lib/uri/common.rb Outdated Show resolved Hide resolved
hsbt and others added 3 commits August 6, 2024 18:06
@hsbt @nobu
Update test/uri/test_common.rb
884df86 
Co-authored-by: Nobuyoshi Nakada <[email protected]>
@hsbt @nobu
Update lib/uri/common.rb
b82842e 
Co-authored-by: Nobuyoshi Nakada <[email protected]>
@hsbt @nobu
Update lib/uri/common.rb
238afb9 
Co-authored-by: Nobuyoshi Nakada <[email protected]>
@hsbt hsbt merged commit c2fdec0 into master Aug 6, 2024
48 checks passed
@hsbt hsbt deleted the fallback-rfc2396 branch August 6, 2024 09:09
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 6, 2024
@hsbt @nobu @matzbot
[ruby/uri] Fallback missing constants with RFC3986_PARSER
267da55 
(ruby/uri#113)

* Fallback missing constants with RFC3986_PARSER

* raise missing constant

* Update test/uri/test_common.rb

Co-authored-by: Nobuyoshi Nakada <[email protected]>

* Update lib/uri/common.rb

Co-authored-by: Nobuyoshi Nakada <[email protected]>

* Update lib/uri/common.rb

Co-authored-by: Nobuyoshi Nakada <[email protected]>

---------

ruby/uri@c2fdec079a

Co-authored-by: Nobuyoshi Nakada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu left review comments

@byroot byroot byroot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imcompatibility issue with RFC3986_PARSER
3 participants
@hsbt @nobu @byroot