Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Move validations into PackageProtections.validate! #40

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

alexevanczuk
Copy link
Contributor

There are many validations that show up to the user when we use PackageProtections APIs like PackageProtections::ProtectedPackage.from(...).

These validations all require that the user set up PackageProtections up correctly.

As we move away from package_proteections and to rubocop-packs, we want to allow packs to opt-out of package protections validations more easily.
To do that, we move all validations into one place. This will also stop validations from happening during modularization_statistics execution, so users can use modularization_statistics without having configured package_protections.

@alexevanczuk alexevanczuk merged commit ceaea07 into main Oct 24, 2022
@alexevanczuk alexevanczuk deleted the ae-move-validations-out-of-band branch October 24, 2022 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant