This repository has been archived by the owner on May 3, 2024. It is now read-only.
Move validations into PackageProtections.validate! #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many validations that show up to the user when we use
PackageProtections
APIs likePackageProtections::ProtectedPackage.from(...)
.These validations all require that the user set up
PackageProtections
up correctly.As we move away from
package_proteections
and torubocop-packs
, we want to allow packs to opt-out of package protections validations more easily.To do that, we move all validations into one place. This will also stop validations from happening during
modularization_statistics
execution, so users can usemodularization_statistics
without having configuredpackage_protections
.