Add enforce_privacy: strict to README.md
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstannard
reviewed
Jan 30, 2024
|
Hi Matt! This addition looks great - just a minor note for readability :) |
Co-authored-by: Teal Stannard <[email protected]>
|
Very good suggestions! Thank you for the review @tstannard 🙇 |
professor
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today I learned about
enforce_privacy: strictafter a colleague asked me if there was a way to "shield" their package from violations, including those in TODO files.Reading the README, I saw mentions about the
strictvalue forenforce_privacy, but there was no explanation of how this differs fromtrue.After testing it locally, I realised this does exactly what we were hoping, so I'm suggesting we add this to the
READMEfor future readers.