Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming architecture to layer #53

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

perryqh
Copy link
Contributor

@perryqh perryqh commented Apr 26, 2024

Background

It was decided that architecture isn't a great name for a violation because most of the violation types can be seen as architecture violations.

Changes

A new violation type, layer, is added. architecture should be considered deprecated.

Layer Violation Architecture Violation
Status New Deprecated
packwerk.yml key layers architecture_layers
package.yml enforcement enforce_layers enforce_architecture
package_todo violation label layer architecture

Release plan

@perryqh perryqh force-pushed the ph/rename-architecture-to-layer branch 6 times, most recently from 740f44d to c9ce6a6 Compare April 29, 2024 23:40
@perryqh perryqh force-pushed the ph/rename-architecture-to-layer branch 4 times, most recently from b53e0b9 to a274de8 Compare April 30, 2024 01:57
@perryqh perryqh changed the title Replacing architecture with layer Renaming architecture with layer Apr 30, 2024
README.md Show resolved Hide resolved
@perryqh perryqh force-pushed the ph/rename-architecture-to-layer branch from a274de8 to 1ccaa98 Compare April 30, 2024 16:16
@perryqh perryqh changed the title Renaming architecture with layer Renaming architecture to layer Apr 30, 2024
@perryqh perryqh force-pushed the ph/rename-architecture-to-layer branch from 1ccaa98 to a9b1ff4 Compare April 30, 2024 16:22
@perryqh perryqh marked this pull request as ready for review May 1, 2024 16:17
@perryqh perryqh merged commit 189a755 into main May 3, 2024
6 checks passed
@perryqh perryqh deleted the ph/rename-architecture-to-layer branch May 3, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants