1090 add default casa logo #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelWyatt
changed the title
compwron
reviewed
Oct 20, 2020
|
|
||
| visit volunteers_path | ||
|
|
||
| expect(page).to have_xpath("//img[@src = '/packs-test/media/src/images/default-logo-c9048fc43854499e952e4b62a505bf35.png' and @alt='CASA Logo']") |
There was a problem hiding this comment.
I don't think that this hash will stay the same over time? But maybe it will?
'/packs-test/media/src/images/default-logo-c9048fc43854499e952e4b62a505bf35.png
There was a problem hiding this comment.
I think this hash will stay the same since we're on webpacker v 5.2, which uses contenthash instead of chunkhash to generate this -- it should be 100% based on the file contents.
That said, I'm happy to update this to just look for 'default-logo' so the test is more resilient :)
There was a problem hiding this comment.
Let's leave it as is and if it breaks then we'll change it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #1090
What changed, and why?
For organizations without a set logo, the sidebar will now display the default CASA logo.
How will this affect user permissions?
No change to permissions.
How is this tested? (please write tests!) 💖💪
spec/system/admin_views_volunteers_page_spec.rbandspec/views/layouts/sidebar.html.erb_spec.rbto ensure xpath to default-logo is present on pageScreenshots please :)
View before change (logged in as [email protected], but this will also change supervisor and volunteer views):
View after change:
Feelings gif (optional)