Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap from 5.1.3 to 5.2.1 #729

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jul 22, 2022

Bootstarap 5.2.0 (GA) and 5.2.1 was released: https://blog.getbootstrap.com/2022/07/19/bootstrap-5-2-0/ and https://blog.getbootstrap.com/2022/09/07/bootstrap-5-2-1/

Bootstrap 5.2.1 fixed the regression introduced as below in 5.2.0.

As of 2022-07-25, Bootstrap 5.2.0 had a regression as below, so we cannot upgrade to 5.2.0. Hopefully we can go with 5.2.1.

Signed-off-by: Takuya Noguchi [email protected]

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tnir-boots-brsxmy July 22, 2022 03:57 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tnir-boots-0pmnpj July 30, 2022 07:21 Inactive
@tnir tnir self-assigned this Aug 18, 2022
@tnir tnir changed the title Bump bootstrap from 5.1.3 to 5.2.0 Bump bootstrap from 5.1.3 to 5.2.1 Sep 13, 2022
@tnir tnir marked this pull request as ready for review September 13, 2022 10:37
Copy link
Collaborator Author

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior in 5.2.1 looks like different from 5.1.x while it is different from 5.2.0 😀 Pushing back to draft...

@tnir tnir marked this pull request as draft September 14, 2022 01:41
@tnir tnir added the architecture/maintenance Daily architecture update label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture/maintenance Daily architecture update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants