Update to use libv8-node 16.x #210

lloeki · 2021-06-22T10:53:42Z

Based on V8 9.0, with node 16 being the new LTS, node 15 now being unsupported. It
notably introduces single threaded mode.

Requiring c++14 is apparently the only change needed for this major. A
separate PR will add a more helpful install time check for compiler
requirements.

lloeki · 2021-06-22T10:57:38Z

Do not merge yet!

libv8-node 16 hasn't been released on ruby gems (hence the test failures), as I need to finalise the CI support for cross compiling to ARM before I have public things out there (even beta).

This early branch allows select testers to proceed with testing on private gems, as well as libv8-node CI's test jobs (which are based on mini_racer) to pass.

lloeki · 2021-07-12T13:03:07Z

Cross-compilation of Node 16 to aarch64-linux is making good progress, so I should be publishing the gems when I get to fix a small (known) issue on musl.

@SamSaffron I have a couple of flaky test failures on x86_64-darwin CI. I think they might be due to the CI machines suffering from the occasional pressure, which makes stuff not happen in a timely manner from time to time. I'm not sure if there's a way to improve these:

Run options: --seed 6360

# Running:

...................S......S......................F........................................

Finished in 4.243624s, 21.2083 runs/s, 35.3471 assertions/s.

  1) Failure:
MiniRacerTest#test_ensure_gc [/Users/runner/work/ruby-libv8-node/ruby-libv8-node/test/mini_racer/test/mini_racer_test.rb:757]:
expecting most of the 1_000_000 long string to be freed

90 runs, 150 assertions, 1 failures, 0 errors, 2 skips

Run options: --seed 17030

# Running:

.........................F....S...............................................S...........

Finished in 4.744077s, 18.9710 runs/s, 31.6184 assertions/s.

  1) Failure:
MiniRacerTest#test_timeout_in_ruby_land [/Users/runner/work/ruby-libv8-node/ruby-libv8-node/test/mini_racer/test/mini_racer_test.rb:645]:
MiniRacer::ScriptTerminatedError expected but nothing was raised.

90 runs, 150 assertions, 1 failures, 0 errors, 2 skips

lloeki · 2021-07-12T15:06:12Z

Had to disable pointer compression (which is experimental) because of this commit.

lloeki · 2021-10-14T14:34:03Z

PR containing 16.x on the libv8-node side: rubyjs/libv8-node#24

Based on V8 9.0, his is the new LTS, node 15 now being unsupported. It notably introduces single threaded mode. Requiring c++14 is apparently the only change needed for this major. A separate PR will add a more helpful install time check for compiler requirements.

Node 16.4.0 introduced new cage flags for the experimental pointer compression stuff. Unfortunately something fails and none of them are set which causes the build to bail out because of the inconsistency.

SamSaffron · 2021-10-19T04:25:08Z

anything to worry about with the various compilation errors?

lloeki · 2021-10-19T13:13:06Z

x86_64 2.6 gnu and 2.7 gnu failed because they picked up x86_64-linux-musl instead of x86_64-linux. Old rubygems issue, fixed upstream.
x86_64 2.6 musl and 2.7 musl failed because they think they're x86_64-linux and points the linker to a nonexistent file. Same old rubygems issue, but manifests differently. I might be able to work around that one within libv8-node.
aarch64-linux-musl libv8-node is unreleased (no cross-compiling for musl), so it picks up aarch64-linux and fails. I'll produce a build using Docker on my M1 machine.
x86_64 3.0 musl failed because of this upstream ruby issue for which IIUC a fix has been merged but not released. IIRC using clang can work around that, or we can try applying the small patch on that Ruby.
Not sure what happened on macOS 11.0, it seems unrelated to mini_racer:

#<Thread:0x00007fcb8d0796e8 /Users/runner/work/mini_racer/mini_racer/test/mini_racer_test.rb:587 run> terminated with exception (report_on_exception is true):
/usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:73:in `bytes': stack level too deep (SystemStackError)
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:260:in `gen_random'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:73:in `bytes'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:260:in `gen_random'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:73:in `bytes'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:260:in `gen_random'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:73:in `bytes'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:260:in `gen_random'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:73:in `bytes'
	 ... 10908 levels...
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:260:in `gen_random'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:155:in `random_bytes'
	from /usr/local/Cellar/[email protected]/2.7.4/lib/ruby/2.7.0/securerandom.rb:176:in `hex'
	from /Users/runner/work/mini_racer/mini_racer/test/mini_racer_test.rb:588:in `block (2 levels) in test_concurrent_access_over_the_same_isolate_2'

SamSaffron · 2021-10-29T05:57:57Z

@lloeki should I go ahead and merge this ? Push a new gem?

lloeki · 2021-10-29T13:23:58Z

I did not manage to work around the old rubygems issues on musl.

If you're OK with the issues and that if people encounter them they can pin to a previous version then go ahead, it's probably well worth it to have a recent libv8 available.

SamSaffron · 2021-10-31T11:01:02Z

I am merging this, but will wait a bit till I push gems for a bit longer

alexeevit · 2021-11-05T09:02:35Z

@lloeki hey hi

x86_64 2.6 gnu and 2.7 gnu failed because they picked up x86_64-linux-musl instead of x86_64-linux. Old rubygems issue, fixed upstream.

x86_64 2.6 musl and 2.7 musl failed because they think they're x86_64-linux and points the linker to a nonexistent file. Same old rubygems issue, but manifests differently. I might be able to work around that one within libv8-node.

I'm not sure what's the difference between these points, but I ran into the issue on my x86_64 Linux VPS. It thinks it's x86_64-linux but it picked up x86-64-linux-musl. Is there a quick workaround to make it work?

lloeki · 2021-11-05T09:52:51Z

@alexeevit it's very subtle, see rubygems/rubygems#3174 for gory details. The true fix is not there yet but are workarounds in latest rubygems and bundler, so what's your rubygems and bundler version?

alexeevit · 2021-11-05T09:54:59Z

@alexeevit it's very subtle, see rubygems/rubygems#3174 for gory details. The true fix is not there yet but are workarounds in latest rubygems and bundler, so what's your rubygems and bundler version?

$ gem -v
3.0.3.1

$ bundler -v
Bundler version 1.17.2

Then I'll try to update them first and come back with the result. Thank you!

UPD:

haha, it's such a pity the project uses rails 4.2 that depends on bundler < 2.0

lloeki · 2021-11-08T13:42:20Z

@alexeevit I've got a gist for you. Make sure to read the note, you probably want to use the code patch instead of the runtime monkeypatch.

https://gist.github.com/lloeki/12dcf61324f64a2fa1e8a8b2109c1f00

tisba mentioned this pull request Jun 25, 2021

0.4.0 crashes on aarch64-linux for Ruby 2.7 + 3.0; LoadError with 2.5 and 2.6 (via Docker for Mac on M1) #190

Closed

lloeki referenced this pull request in rubyjs/libv8-node Jul 12, 2021

Fix compatibility with psych 4.0

6bbb084

lloeki force-pushed the libv8-node-16 branch from b756f8d to f42c647 Compare July 12, 2021 15:04

lloeki changed the title ~~Update to use libv8-node 16.3.0~~ Update to use libv8-node 16.x Jul 12, 2021

lloeki mentioned this pull request Oct 13, 2021

Update to 8.4.255 rubyjs/libv8#301

Merged

lloeki added 3 commits October 18, 2021 12:07

Disable pointer compression

297f79e

Node 16.4.0 introduced new cage flags for the experimental pointer compression stuff. Unfortunately something fails and none of them are set which causes the build to bail out because of the inconsistency.

Update to use libv8-node 16.10.0

9ac5e7a

lloeki force-pushed the libv8-node-16 branch from f42c647 to 9ac5e7a Compare October 18, 2021 10:36

SamSaffron merged commit 8bd860b into master Oct 31, 2021

ryantm mentioned this pull request Nov 24, 2021

discourse: 2.7.9 -> 2.8.0.beta8, update plugins NixOS/nixpkgs#147277

Closed

13 tasks

SamSaffron deleted the libv8-node-16 branch May 28, 2023 22:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to use libv8-node 16.x #210

Update to use libv8-node 16.x #210

lloeki commented Jun 22, 2021 •

edited

Loading

lloeki commented Jun 22, 2021

lloeki commented Jul 12, 2021 •

edited

Loading

lloeki commented Jul 12, 2021

lloeki commented Oct 14, 2021

SamSaffron commented Oct 19, 2021

lloeki commented Oct 19, 2021

SamSaffron commented Oct 29, 2021

lloeki commented Oct 29, 2021 •

edited

Loading

SamSaffron commented Oct 31, 2021

alexeevit commented Nov 5, 2021

lloeki commented Nov 5, 2021

alexeevit commented Nov 5, 2021 •

edited

Loading

lloeki commented Nov 8, 2021

Update to use libv8-node 16.x #210

Update to use libv8-node 16.x #210

Conversation

lloeki commented Jun 22, 2021 • edited Loading

lloeki commented Jun 22, 2021

lloeki commented Jul 12, 2021 • edited Loading

lloeki commented Jul 12, 2021

lloeki commented Oct 14, 2021

SamSaffron commented Oct 19, 2021

lloeki commented Oct 19, 2021

SamSaffron commented Oct 29, 2021

lloeki commented Oct 29, 2021 • edited Loading

SamSaffron commented Oct 31, 2021

alexeevit commented Nov 5, 2021

lloeki commented Nov 5, 2021

alexeevit commented Nov 5, 2021 • edited Loading

lloeki commented Nov 8, 2021

lloeki commented Jun 22, 2021 •

edited

Loading

lloeki commented Jul 12, 2021 •

edited

Loading

lloeki commented Oct 29, 2021 •

edited

Loading

alexeevit commented Nov 5, 2021 •

edited

Loading