Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two performance improvements #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Two performance improvements #19

wants to merge 2 commits into from

Commits on Sep 18, 2018

  1. Performance improvement 

    - If the object being converted is already a DateTime, we can pass it directly to the RiCal DateTime constructor as-is, since that constructor already has support to skip stringifying/text parsing if a DateTime object is passed
    Ian Clarkson committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    6ec86bc View commit details
    Browse the repository at this point in the history

  2. Performance improvement 

    - Checking equality via the `==` method involved a significant amount of computation
- I found that the majority of the time equality was being checked, parent and timezone_finder were actually the exact same object instance
- By checking for `equal?` first, we do a much simpler/faster (which is also more strict) first, allowing us to shortcut the lengthier equality comparison if the objects are actually the same instance
    Ian Clarkson committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    e7b66c3 View commit details
    Browse the repository at this point in the history