This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
fix: only check for the header unless Nokogiri provides LDFLAGS #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in which case, then we verify that we can resolve libxml symbols. Related to a41ab09 which checked symbol resolution on both Linux and Windows; but it fails (and is unnecessary) on Linux, leading to seeing this at installation: > checking for xmlNewDoc() in libxml/tree.h... no
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in which case, then we verify that we can resolve libxml symbols.
Related to a41ab09 which checked symbol resolution on both Linux
and Windows; but it fails (and is unnecessary) on Linux, leading to
seeing this at installation: