-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
able to use with rails 4.2.1 too #659
base: rails4
Are you sure you want to change the base?
Conversation
Since there is a bug in Rails 4.2 that causes Forem to double-increment views, I don't recommend to use Forem with Rails 4.2 until that bug is fixed (#640). If you are fine with that, go ahead! 😄 |
I am not fine with having Forem support a version of Rails with a known regression. Therefore I won't be accepting this PR until Rails 4.2.2 is released. |
hey @radar Rails 4.2.2 is already released, can you accept PR? |
Does 4.2.2 contain the specified patch or is it just security releases?
|
@radar it seems not... |
Actually counter caches are broken in all of Rails 4.2 versions. Forem Rails dependency should be s.add_dependency 'rails', '~> 4.0', '< 4.2' instead of s.add_dependency 'rails', '~> 4.0', '<= 4.2' |
I'm fine with leaving the dependency as it is now. If people complain about the counter cache issue, we can point them to this issue. |
The counter issue is fixed in Rails 4.2.4. Could you please update the dependency to Rails 4.2.4, 4.2.5, and above? Thanks. |
Is not it already updated? |
No description provided.