Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds 3 streams #138

Merged
merged 15 commits into from
Jul 20, 2023
Merged

feat: adds 3 streams #138

merged 15 commits into from
Jul 20, 2023

Conversation

a-rampalli
Copy link

What

Adds 3 streams Triggers, Views, Automations

How

https://www.notion.so/rudderstacks/Add-code-for-Triggers-Automations-Views-resources-bf45b7702ff343dc9c29e6ee06aced04?pvs=4#af36549cfd3143d89403a1d40bc5d4d0

Testing

Have run the streams locally and the connector is fetching data consistent with api responses

@github-actions
Copy link

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link

@am6010 am6010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think there is a possible misconfiguration in the query params

@a-rampalli a-rampalli requested a review from am6010 July 18, 2023 10:00
@a-rampalli a-rampalli marked this pull request as draft July 18, 2023 10:18
@a-rampalli a-rampalli marked this pull request as ready for review July 19, 2023 10:02
Copy link

@RanjeetMishra RanjeetMishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please get it reviewed by @am6010 as well. Too many weird scenarios for Zendesk resources :P

@a-rampalli a-rampalli merged commit 430b14a into main Jul 20, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants