-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds 3 streams #138
feat: adds 3 streams #138
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think there is a possible misconfiguration in the query params
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please get it reviewed by @am6010 as well. Too many weird scenarios for Zendesk resources :P
What
Adds 3 streams Triggers, Views, Automations
How
https://www.notion.so/rudderstacks/Add-code-for-Triggers-Automations-Views-resources-bf45b7702ff343dc9c29e6ee06aced04?pvs=4#af36549cfd3143d89403a1d40bc5d4d0
Testing
Have run the streams locally and the connector is fetching data consistent with api responses