fix: adds client side filtering to export #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We wanted to fix the param being sent to export api so that we get data from the timestamp we want. Turns out if we do that ordering of records will not hold in the api response we get. Not having ordering will create problems in us storing state at regular intervals. This is a bigger problem because of the
unexpected end of json errors
So we are doing client side filtering of records fetched from export api.
Testing
The records now are ordered by time and also have
time
value more than state{"export": {"time": "2023-08-09T10:59:59Z"}}
If we set state value greater than end date we get 0 records as intended