Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the version of iOS SDK to address the Privacy Manifest issue #342

Conversation

1abhishekpandey
Copy link
Contributor

Description of the change

  • We have updated the minimum iOS SDK version in the React Native SDK to v1.26.3 to address the following issue:

We've decided to remove the tracking domain URL from the Privacy Manifest file. This change aims to resolve the error that occurs when a request to our tracking domain gets blocked after the user denies tracking permission.
Refer to this PR: rudderlabs/rudder-sdk-ios#509.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@1abhishekpandey 1abhishekpandey self-assigned this Apr 23, 2024
…e-ios-sdk-version-in-react-native-to-address-the
…e-ios-sdk-version-in-react-native-to-address-the
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@1abhishekpandey 1abhishekpandey merged commit d81214c into develop Apr 24, 2024
9 checks passed
@1abhishekpandey 1abhishekpandey deleted the fix/sdk-1712-update-ios-sdk-version-in-react-native-to-address-the branch April 24, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants