Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Add an extra check for if the WASM download failed #17978

Conversation

danielhjacobs
Copy link
Contributor

No description provided.

@torokati44
Copy link
Member

For context, the full message text might be something like this:
"WebAssembly compilation aborted: Network error: Failed to read from a ReadableStream."

(According to your message on Discord.)

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Sep 18, 2024

Yup:

https://github.com/ruffle-rs/ruffle/issues?q=is%3Aissue+is%3Aopen+%22WebAssembly+compilation+aborted%3A+Network+error%3A+Failed+to+read+from+a+ReadableStream%22+

I assume this has been a possible error since #7396, but it may be newer, as the first report about it was Nov 9, 2023 (with a build from September 1)

@danielhjacobs danielhjacobs added A-web Area: Web & Extensions T-fix Type: Bug fix (in something that's supposed to work already) labels Sep 18, 2024
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Sep 18, 2024

Also of note is that this is likely the most common error being suppressed by the problem fixed by #17976, which is why it hasn't come up in any reports of recent builds.

@danielhjacobs danielhjacobs force-pushed the extra-wasm-download-failure-check branch from 9a7bc46 to 3654e91 Compare September 20, 2024 19:31
@danielhjacobs danielhjacobs enabled auto-merge (rebase) September 20, 2024 19:31
@danielhjacobs danielhjacobs merged commit 09b3bc2 into ruffle-rs:master Sep 20, 2024
15 checks passed
@danielhjacobs danielhjacobs deleted the extra-wasm-download-failure-check branch September 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web Area: Web & Extensions T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants